Skip to content

fix dockerfile warnings #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

fix dockerfile warnings #1098

merged 1 commit into from
Aug 12, 2025
+5 −6

Conversation

SergeyKanzhelev
Copy link
Member

Every build showing this warnings. Fixing:

- FromAsCasing: 'as' and   │
│    'FROM' keywords' casing do not match (line 23)                                               │
│     - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 38)                     │
│     - RedundantTargetPlatform: Setting platform to predefined ${TARGETPLATFORM} in FROM is      │
│    redundant as this is the default behavior (line 38)                                          │
│     - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value"    │
│    format (line 28)                                                                             │
│     - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value"    │
│    format (line 29)                                                                             │
│     - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 22)                     │
│    Dockerfile:36

(change is made by gemini)

Also removed the LABEL maintainer="Andy Xie <[email protected]>" manually as it is being overwritten by the next tag anyways. We may need to update this metadata.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 12, 2025
@hakman
Copy link
Member

hakman commented Aug 12, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 72b1cc5 into kubernetes:master Aug 12, 2025
14 checks passed
@SergeyKanzhelev SergeyKanzhelev deleted the dockerfilewarnings branch August 12, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@mmiranda96 mmiranda96 Awaiting requested review from mmiranda96

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SergeyKanzhelev @hakman @k8s-ci-robot